feat: fix game-name matching and add a game vs wiki cross-check #9

Merged
ryan.mcgee merged 1 commit from feat/crosscheck-report into main 2026-11-19 04:09:45 +00:00
Owner

Summary

  • Add a local game-vs-wiki cross-check report, and fix three matching bugs it exposed in gamemap.py (which ships to players).

Matching fixes in static/tools/gamemap.py

  • All-letter asset ids (about 1 in 140) were rejected by a "mixes letters with digits" shortcut. They are now accepted when the string is not in the asset's name table (where words and keys live, and ids don't). This is why Coal was missed.
  • Seed names live in ST_Farming (keys like Name_Seed_Cabbage); values from per-feature tables were only used for tables with "Name" in the file name.
  • Plural differences ("Bronze Bolt" vs "Bronze Bolts") now match, exact first.
  • Candidate ranking keeps name-table values first; broader table values are tried last, which avoids a stray value (LawRune) outranking the right name.
  • Result on build 26670300: mapped items 1353 -> 1663; a real save's picked-up item coverage 367 -> 419 of 446; 0 existing mappings changed, 0 lost (compared against the previous output).
  • extract_assets, iter_assets and site_matcher are factored out so other tools can reuse them; main() behaviour is unchanged.

scripts/crosscheck.py

  • Compares the game's item and quest assets with the wiki-derived index using the same extraction and matching. Reports: matched, item-like game-only, assets under a Deleted folder, non-item data, wiki-only items, suspected renames (found wiki typos such as Marentill Seeds, Naptha, Slightly Chaffing Chestguard), and quest differences.
  • The report names game assets, so the output file is gitignored and the README says not to commit it.

Verification

  • py_compile OK; gamemap.py end to end in a clean python:3.13-slim container (1663 items, 37 quests, build 26670300); crosscheck.py run on the same build
  • Cross-check on build 26670300: 2695 game assets with ids, 1663 matched, 331 item-like game-only, 20 under Deleted, 681 other data; 1255 of 1333 wiki items have a game asset (78 without)
  • No game ids appear in any tracked file

Notes

  • "Game only" is a lead, not a to-do list: it contains test items, [PH] placeholders, _OLD versions, colour variants and vendor purchase recipes.
## Summary - Add a local game-vs-wiki cross-check report, and fix three matching bugs it exposed in `gamemap.py` (which ships to players). ## Matching fixes in `static/tools/gamemap.py` - All-letter asset ids (about 1 in 140) were rejected by a "mixes letters with digits" shortcut. They are now accepted when the string is not in the asset's name table (where words and keys live, and ids don't). This is why Coal was missed. - Seed names live in `ST_Farming` (keys like `Name_Seed_Cabbage`); values from per-feature tables were only used for tables with "Name" in the file name. - Plural differences ("Bronze Bolt" vs "Bronze Bolts") now match, exact first. - Candidate ranking keeps name-table values first; broader table values are tried last, which avoids a stray value (`LawRune`) outranking the right name. - Result on build 26670300: mapped items 1353 -> 1663; a real save's picked-up item coverage 367 -> 419 of 446; **0 existing mappings changed, 0 lost** (compared against the previous output). - `extract_assets`, `iter_assets` and `site_matcher` are factored out so other tools can reuse them; `main()` behaviour is unchanged. ## `scripts/crosscheck.py` - Compares the game's item and quest assets with the wiki-derived index using the same extraction and matching. Reports: matched, item-like game-only, assets under a `Deleted` folder, non-item data, wiki-only items, suspected renames (found wiki typos such as `Marentill Seeds`, `Naptha`, `Slightly Chaffing Chestguard`), and quest differences. - The report names game assets, so the output file is gitignored and the README says not to commit it. ## Verification - `py_compile` OK; `gamemap.py` end to end in a clean `python:3.13-slim` container (1663 items, 37 quests, build 26670300); `crosscheck.py` run on the same build - Cross-check on build 26670300: 2695 game assets with ids, 1663 matched, 331 item-like game-only, 20 under `Deleted`, 681 other data; 1255 of 1333 wiki items have a game asset (78 without) - No game ids appear in any tracked file ## Notes - "Game only" is a lead, not a to-do list: it contains test items, `[PH]` placeholders, `_OLD` versions, colour variants and vendor purchase recipes.
feat: fix game-name matching and add a game vs wiki cross-check
All checks were successful
deploy / build (pull_request) Successful in 44s
b9950ebd52
- gamemap.py: accept all-letter ids (about 1 in 140), use values from
  per-feature string tables (seeds), and match plural names, taking
  mapped items from 1353 to 1663 and one save from 367 to 419 of 446
  picked-up items, with no existing mapping changed
- gamemap.py: expose extract_assets, iter_assets and site_matcher for
  reuse
- scripts/crosscheck.py: local-only report of game-only items, wiki-only
  items, items the game marks Deleted, suspected renames and quest
  differences; the report is gitignored
- document it in the README
ryan.mcgee deleted branch feat/crosscheck-report 2026-11-19 04:09:45 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
UltraVu-Studios/rsdclog!9
No description provided.