refactor: single import button and a dialog that reuses the mapping #8

Merged
ryan.mcgee merged 2 commits from refactor/single-import-button into main 2026-11-19 03:52:30 +00:00
Owner

Summary

  • Remove the info (i) button next to "Import game save"; the Import button now always opens the dialog.
  • Make the dialog reuse an existing mapping so returning users only pick their save.

Changes

  • Single Import button that always opens the dialog. Previously it skipped the dialog once a mapping was stored, which made the info button the only way to reopen it and load a new mapping after a game update.
  • The dialog adapts to state: the loaded mapping (size, game build, date) is shown first with "Load a different mapping"; the how-to for making a mapping is a collapsible section that is open only when no mapping is stored (and collapses as soon as one is loaded); focus lands on "Choose character save" when a mapping exists, or on "Load gamemap.json" otherwise. The numbered steps are gone since their order now depends on state.
  • Removed the now unused toolbar group style; README updated.

Verification

  • node --check and zola build: OK
  • Browser: no info button; with no mapping the how-to is open and focus is on Load; loading a mapping collapses the how-to; importing via the dialog ticked 363 items and 23 quests; on a return visit (after reload) the mapping is reused, the how-to is collapsed and focus is on "Choose character save"; the how-to can be expanded manually; Esc closes; no console errors

Notes

  • The character save itself can't be remembered: browsers don't let a page re-read a previously picked file without asking again, and the save changes as you play anyway.
## Summary - Remove the info (i) button next to "Import game save"; the Import button now always opens the dialog. - Make the dialog reuse an existing mapping so returning users only pick their save. ## Changes - Single Import button that always opens the dialog. Previously it skipped the dialog once a mapping was stored, which made the info button the only way to reopen it and load a new mapping after a game update. - The dialog adapts to state: the loaded mapping (size, game build, date) is shown first with "Load a different mapping"; the how-to for making a mapping is a collapsible section that is open only when no mapping is stored (and collapses as soon as one is loaded); focus lands on "Choose character save" when a mapping exists, or on "Load gamemap.json" otherwise. The numbered steps are gone since their order now depends on state. - Removed the now unused toolbar group style; README updated. ## Verification - `node --check` and `zola build`: OK - Browser: no info button; with no mapping the how-to is open and focus is on Load; loading a mapping collapses the how-to; importing via the dialog ticked 363 items and 23 quests; on a return visit (after reload) the mapping is reused, the how-to is collapsed and focus is on "Choose character save"; the how-to can be expanded manually; Esc closes; no console errors ## Notes - The character save itself can't be remembered: browsers don't let a page re-read a previously picked file without asking again, and the save changes as you play anyway.
refactor: remove the info button, import opens the dialog
All checks were successful
deploy / build (pull_request) Successful in 43s
5f28b3b71e
- the Import game save button now always opens the dialog, so the
  separate info button is redundant
- the dialog already holds loading a mapping and choosing a save, so
  loading a new mapping after a game update still has a place
- drop the now unused toolbar group style and update the README
feat: make the import dialog adapt to a stored mapping
All checks were successful
deploy / build (pull_request) Successful in 43s
77ad77fe60
- the stored mapping is reused; the dialog shows it up front and
  collapses the how-to once a mapping exists
- focus lands on "Choose character save" when a mapping exists, or on
  "Load gamemap.json" otherwise
- drop the numbered steps now that the order depends on state
ryan.mcgee changed title from refactor: remove the info button, import opens the dialog to refactor: single import button and a dialog that reuses the mapping 2026-11-19 03:49:41 +00:00
ryan.mcgee deleted branch refactor/single-import-button 2026-11-19 03:52:30 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
UltraVu-Studios/rsdclog!8
No description provided.